awesome_file works with closed file #141
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case:
echo "a\nb\nc" > /tmp/test
irb
irb >
File.open("/tmp/test") { |file| file.each_line { |line| puts "Got #{ line.dump }" } }
Log:
Got "a\nb\nc\n"
IOError: closed stream
from /Users/user/.rvm/gems/ruby-2.1.0-preview1/gems/awesome_print-1.2.0/lib/awesome_print/formatter.rb:199:in `directory?'
Root cause:
File.directory?(f)
asks closed f(ile)It looks like it isn't necessary to do this check. If
ls -d
runs for file, '-d' - is ignored