Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up old Rubies and Rails #189

Open
maurogeorge opened this issue Feb 26, 2015 · 5 comments · May be fixed by #193
Open

Clean up old Rubies and Rails #189

maurogeorge opened this issue Feb 26, 2015 · 5 comments · May be fixed by #193
Milestone
v2

Comments

@maurogeorge
Copy link
Collaborator

clean up the code to get rid of Ruby 1.8.x-only hacks. I think by now it's safe to drop support for 1.9.3 as well and focus on Ruby v2.x only. I think we can certainly drop Rails v2 but I'm not so sure about dropping Rails v3.

Created based on the idea of @michaeldv about the future of the project
@maurogeorge maurogeorge added this to the v2 milestone Feb 26, 2015
@imajes
Copy link
Collaborator

imajes commented Feb 26, 2015

Yeah i think that's a good idea. makes sense to signpost on README that the current release is the last one that supports 1.8x and Rails 2x.

@maurogeorge maurogeorge linked a pull request Mar 18, 2015 that will close this issue
Open
@gerrywastaken
Copy link
Contributor

Sounds good to me.

@waldyr How do you feel about us dropping support for anything below Ruby 2.0?

We are already running into build issues on Travis every time somebody drops support in their gem resulting in the addition of many gem <old version goes here>, :platforms => :ruby_19 lines to our Appraisals file.
https://github.com/awesome-print/awesome_print/blob/master/Appraisals

Just yesterday the json gem's dropped support for old rubies resulted in failed builds: #255

I suggest officially dropping support for 1.9 after the next release and removing/updating redundant code as convenient in a piecemeal fashion.

@waldyr
Copy link
Contributor

waldyr commented Jul 5, 2016

I agree with that. 👍

@gerrywastaken
Copy link
Contributor

@waldyr Cheers

@waldyr
Copy link
Contributor

waldyr commented Jul 5, 2016

Also this is one thing @michaeldv pointed out it should be done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Awesome Print vN.... (was v2, but not anymore..) awesome-print/awesome_print
4 participants
@imajes @gerrywastaken @maurogeorge @waldyr