From 663c69bdad7cf0476be3f71cef1e7fadbfbf3ff1 Mon Sep 17 00:00:00 2001 From: Andrew DeOrio Date: Fri, 1 Nov 2024 10:02:38 -0400 Subject: [PATCH 1/3] Fix pylint error --- mailmerge/__main__.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/mailmerge/__main__.py b/mailmerge/__main__.py index fbf4942..7b10506 100644 --- a/mailmerge/__main__.py +++ b/mailmerge/__main__.py @@ -62,7 +62,7 @@ type=click.Choice(["colorized", "text", "raw"]), help="Output format (colorized).", ) -def main(sample, dry_run, limit, no_limit, resume, +def main(*, sample, dry_run, limit, no_limit, resume, template_path, database_path, config_path, output_format): """ @@ -74,7 +74,6 @@ def main(sample, dry_run, limit, no_limit, resume, # We need an argument for each command line option. That also means a lot # of local variables. # pylint: disable=too-many-arguments - # pylint: disable=too-many-positional-arguments # pylint: disable=too-many-locals # Convert paths from string to Path objects @@ -143,9 +142,7 @@ def main(sample, dry_run, limit, no_limit, resume, if __name__ == "__main__": - # No value for parameter, that's how click works - # pylint: disable=no-value-for-parameter - main() + main() # pylint: disable=missing-kwoa def check_input_files(template_path, database_path, config_path, sample): From e6237c789e1428a7c1b2c99cbd3a61347c9cfbed Mon Sep 17 00:00:00 2001 From: Andrew DeOrio Date: Mon, 4 Nov 2024 17:10:06 -0500 Subject: [PATCH 2/3] bump GH Action CodeCov version --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 17a3a22..085b9ed 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -55,6 +55,6 @@ jobs: # Upload coverage report # https://github.com/codecov/codecov-action - name: Upload coverage report - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v4 with: fail_ci_if_error: true From 4a6af964afe449918ba12e79d2d29addd9aaebfe Mon Sep 17 00:00:00 2001 From: Andrew DeOrio Date: Wed, 6 Nov 2024 15:39:29 -0500 Subject: [PATCH 3/3] Configure CodeCov token from GH Secrets --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 085b9ed..f205969 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -57,4 +57,6 @@ jobs: - name: Upload coverage report uses: codecov/codecov-action@v4 with: + token: ${{ secrets.CODECOV_TOKEN }} + slug: awdeorio/mailmerge fail_ci_if_error: true