Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_dims() doesn't account for displays with color depths less than 8bpp #10

Open
avsa242 opened this issue Jan 22, 2024 · 0 comments
Open

set_dims() doesn't account for displays with color depths less than 8bpp #10

avsa242 opened this issue Jan 22, 2024 · 0 comments
Assignees
@avsa242
Labels
limitation Not a bug per se, just a functional limitation

Comments

@avsa242
Copy link
Owner

avsa242 commented Jan 22, 2024

_buff_sz and _bytesperln are calculated based on the assumption that BYTESPERPX is >= 1
Since this can't really be fractional, it isn't calculated quite correctly for displays with bpp < 8 (e.g., monochrome displays like SSD1306).
There probably should be a new divider symbol incorporated into these calculations for these cases.
@avsa242 avsa242 added the limitation Not a bug per se, just a functional limitation label Jan 22, 2024
@avsa242 avsa242 self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avsa242 avsa242

Labels
limitation Not a bug per se, just a functional limitation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avsa242