You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, there are three different versions of the delay code in this repository: The version in master (from the karabut branch), the version in rerewrite (my rewrite), and the version in cyacc (the cycle-accurate version by @bombela).
Before we potentially release this crate on crates.io, we need to decide which one of these versions we are going to release, and merge that version into master.
The text was updated successfully, but these errors were encountered:
My personal opinion is we should release the cyacc implementation, since it guarantees that the delays are known at compile time, which is an important property for ensuring correctness.
I'm a little concerned about the syntax (do we really want the only way to delay on AVR in Rust to involve syntax like delay_ms::<{delay_time}>()?), which is why I introduced the macros PR, but even if that PR isn't accepted I still think it's the best version of the code.
Currently, there are three different versions of the delay code in this repository: The version in
master
(from thekarabut
branch), the version inrerewrite
(my rewrite), and the version incyacc
(the cycle-accurate version by @bombela).Before we potentially release this crate on crates.io, we need to decide which one of these versions we are going to release, and merge that version into
master
.The text was updated successfully, but these errors were encountered: