Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier assignment issues #1387

Closed
mahalakshme opened this issue Nov 29, 2024 · 9 comments
Closed

Identifier assignment issues #1387

mahalakshme opened this issue Nov 29, 2024 · 9 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Nov 29, 2024

https://avni.freshdesk.com/a/tickets/4978

Issue:

  • After editing an identifier user assignment, shows an error message stating 'Element doesn't exist'. Considering the update was successful, it shouldn't show such error messages and should work fine.
  • When a user is not assigned prefix, then 'Identifier prefix is not assigned to the user' error message should get displayed instead of 'Server communication error'

https://drive.google.com/file/d/1EaE6nNYevlRk6xvZOAHxTtHuHA5CIJFg/view?usp=drive_link

@mahalakshme mahalakshme converted this from a draft issue Nov 29, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Nov 29, 2024
@mahalakshme mahalakshme added the good first issue Good for newcomers label Nov 29, 2024
@vedfordev
Copy link
Contributor

have similar steps as #1289

@adamsanadi6 adamsanadi6 self-assigned this Dec 2, 2024
@adamsanadi6 adamsanadi6 moved this from Ready to In Progress in Avni Product Dec 2, 2024
adamsanadi6 added a commit to avniproject/avni-server that referenced this issue Dec 3, 2024
…s on edit- 'Element doesn't exist' and 'Identifier prefix is not assigned to the user'.
@adamsanadi6 adamsanadi6 moved this from In Progress to Code Review Ready in Avni Product Dec 3, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 5, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Dec 5, 2024

Following change in IdentifierUserAssignmentWebController.getIdentifierUserAssignment should not be required

        identifierUserAssignment.setId(request.getId());
        identifierUserAssignment.setOrganisationId(request.getOrganisationId());

@1t5j0y 1t5j0y moved this from In Code Review to Code Review with Comments in Avni Product Dec 5, 2024
@adamsanadi6
Copy link
Contributor

@1t5j0y Yes, we don’t need organisation_id, but we do need to set the id.
Reason: After the PUT method (web/identifierUserAssignment/) is triggered, it takes the id from the PUT method response and uses it in the subsequent GET method. Without setting the id, the next GET request will fail with a 400 Bad Request error because it sends null instead of the expected id.

@adamsanadi6 adamsanadi6 moved this from Code Review with Comments to In Progress in Avni Product Dec 5, 2024
@adamsanadi6
Copy link
Contributor

avniproject/avni-server@c79a79f

Wrongly tagged to a different card.

@1t5j0y 1t5j0y moved this from In Progress to In Code Review in Avni Product Dec 5, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Dec 5, 2024
@dinesh2096 dinesh2096 self-assigned this Dec 9, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Dec 9, 2024
@dinesh2096
Copy link

Unable to select the user

Refer screenshot :

Screen.Recording.2024-12-09.at.5.13.02.PM.mov

@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Dec 9, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Dec 11, 2024

@dinesh2096 have put in a quick fix to address this issue

@1t5j0y 1t5j0y moved this from QA Failed to QA Ready in Avni Product Dec 11, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Dec 11, 2024
@mahalakshme
Copy link
Contributor Author

@dinesh2096 also need to check how it will work with user pool identifier source

@dinesh2096
Copy link

The page is not getting refresh and not coming back to the User assignment page :

Reference Video :

Click here to watch the video

@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Dec 11, 2024
@dinesh2096 dinesh2096 moved this from QA Failed to QA Ready in Avni Product Dec 12, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Dec 12, 2024
@dinesh2096
Copy link

Created the bug card related to user assignment but not related to the card

avniproject/avni-client#1555

@dinesh2096 dinesh2096 moved this from In QA to Done in Avni Product Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

6 participants