Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Disable auto refresh to be applicable on all dashboards #1452

Closed
Tracked by #1581
mahalakshme opened this issue Jul 4, 2024 · 2 comments
Closed
Tracked by #1581
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jul 4, 2024

As is:

Currently this auto refresh is applicable on only MyDashboard

AC:

  • When 'Dashboard Auto Refresh' setting is enabled for a user, all dashboards need to have its own refresh icon and last refreshed date.
Screenshot 2024-07-08 at 1 22 03 PM
  • Like shown in the image remove the pink message that says 'You may need to press refresh to get the latest counts' and instead of just 'Last updated on', display as 'Report card numbers last updated on'. This text need to be platform supported in different existing languages.
  • When refresh icon on a dashboard is clicked it needs to refresh counts of cards of that dashboard alone
  • When a new card is added to the dashboard in webapp, and it's count is not yet cached, display 'Not yet calculated'
  • When a card is removed from the dashboard in webapp, rendering dashboard should not error out

Tech tasks:

  • Unify DashboardCache and CustomDashboardCache realm tables - this is about storing new data of counts and filters, migration is separate card.
  • Add cardJSON column for each custom dashboard as well in realm table
@mahalakshme mahalakshme converted this from a draft issue Jul 4, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Jul 4, 2024
@mahalakshme mahalakshme changed the title Disable dashboard auto refresh to be applicable on any home dashboard [Dashboard] Disable dashboard auto refresh to be applicable on any home dashboard Jul 7, 2024
@mahalakshme mahalakshme changed the title [Dashboard] Disable dashboard auto refresh to be applicable on any home dashboard [Dashboard] Disable dashboard auto refresh to be applicable on all dashboards Jul 7, 2024
@mahalakshme mahalakshme changed the title [Dashboard] Disable dashboard auto refresh to be applicable on all dashboards [Dashboard] Disable auto refresh to be applicable on all dashboards Jul 7, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Jul 8, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jul 8, 2024
@petmongrels petmongrels self-assigned this Jul 8, 2024
@petmongrels
Copy link
Contributor

petmongrels commented Jul 8, 2024

  • When card is pressed the number of subjects shown may vary from the count shown, due to cache. So updating the count cache for the specific report card when the user does this.
  • After sync the counts are not updated or cleared (sync can happen too often)
  • Currently the dashboard on didFocus gives the impression that it is loading the data. Given that the data is cached, we don't need to do this on didFocus.

development notes

Key events, conditional on auto refresh setting

  • filter cleared (clear result cache, get aggregates)
  • filter applied (clear result cache, get aggregates). Even if filter is applied without any change this would happen, not simple to do diff of previous and current filters
  • sync completed (reset dashboards primary / secondary status, clear removed cards from cache)
  • on dashboard load (get aggregates)
  • on dashboard change (get aggregates)
  • enable auto refresh (clear all dashboard result cache, get aggregates)
  • disable auto refresh (get aggregates)
  • force refresh (clear all dashboard result cache, get aggregates)

tasks

  • check for localised message on error (done)
  • try to go to the same dashboard that is primary, via all dashboards. check results. (done)
  • replace countUpdateTime with dashboard cache update time (done)
  • saving of nested report card results to cache (done)
  • on disable cache display of dashboard without any filters (can be done in display selected filters as styling will have to be changed again)

problem with new card coming after sync

  • it is complicating the logic too much. This is the first time scenario as well.

@petmongrels
Copy link
Contributor

petmongrels commented Jul 10, 2024

QA, Bug Bash

  • nested, non-nested
  • auto refresh enabled/disabled
  • new card added, removed and then sync
  • exception in rule
  • wrong number of nested items returned by nested rule
  • standard report card or rule based report card
  • filter applied
  • filter cleared
  • dashboard change
  • force refresh
  • presence / absence of cache
  • filters with no value selected

petmongrels added a commit to avniproject/avni-models that referenced this issue Jul 10, 2024
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jul 12, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Progress in Avni Product Jul 12, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Jul 17, 2024
petmongrels added a commit to avniproject/avni-server that referenced this issue Jul 17, 2024
petmongrels added a commit that referenced this issue Jul 17, 2024
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jul 17, 2024
sachsk pushed a commit to avniproject/avni-server that referenced this issue Jul 22, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Aug 19, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Aug 20, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Aug 20, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants