Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Translation for keys with dynamic values #1444

Closed
Tracked by #1368
Dinesh2019 opened this issue Jun 28, 2024 · 5 comments
Closed
Tracked by #1368

[Documentation] Translation for keys with dynamic values #1444

Dinesh2019 opened this issue Jun 28, 2024 · 5 comments
Assignees

Comments

@Dinesh2019
Copy link

Dinesh2019 commented Jun 28, 2024

We have uploaded the translation in the lokalise for some sentence we have translation but not displayed in the cilent app.

Env : prod
org : apfodisha
user : dinesh@apfodisha

Steps to reproduce :

1.Upload the bundle in the lokalise
2.Login to the cilent app
3.Change the language to odisa
4.enroll the pregancy program
5.Under the weight give the value as 100

Expected : error should be displayed in the odisha language
Actual : still displays in english

Refer screenshot :

Screenshot 2024-06-28 at 12 12 49 PM

file uploaded in lokalise :

no_filename.json

form details :
Pending for translation.xlsx

Root cause:

Its because the above kind of messages which can have dynamic values, doesn't need translation for each msg. Instead the generic keys needs translations: numberAboveHiAbsolute and numberBelowLowAbsolute

AC:

  • Move the readme here to under 'End User Guide'
  • Add steps on how to translate keys with dynamic values, Eg keys: numberAboveHiAbsolute and enrolmentSavedMsg
  • Delete the contents here and add a redirection link to the new above page since the users might have the link of the old page still.

Analysis note:

I understand the difficulty of moving documentation from docs to readme. It was so because of a different process agreed with other teams. Going forward we can update directly in readme.

@mahalakshme
Copy link
Contributor

mahalakshme commented Jun 28, 2024

@Dinesh2019 also mention the form name, steps to reproduce the issue.

I dont see trnaslation for 'should be 90, or less than 90' in the json file. Is the error message dynamically generated? from some rule?

@AnjaliBhagabati
Copy link

@mahalakshme this issue is happening will all the translations mentioned as not yet in this sheet in column "
Uploading Pending for translation.xlsx…
F"

@AnjaliBhagabati
Copy link

@mahalakshme here is the json file
Uploading or1.json…

@mahalakshme mahalakshme moved this from New Issues to In Analysis in Avni Product Aug 29, 2024
@mahalakshme
Copy link
Contributor

It will work when translations added for keys: numberBelowLowAbsolute and numberAboveHiAbsolute

@mahalakshme mahalakshme changed the title Translation is not updated in the cilent app Translation for keys with dynamic values Aug 29, 2024
@mahalakshme mahalakshme removed the bug label Aug 29, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Aug 29, 2024
@mahalakshme mahalakshme changed the title Translation for keys with dynamic values [Documentation] Translation for keys with dynamic values Aug 29, 2024
@himeshr himeshr self-assigned this Aug 30, 2024
@himeshr himeshr moved this from Ready to In Progress in Avni Product Aug 30, 2024
@himeshr
Copy link
Contributor

himeshr commented Aug 30, 2024

  • configured the path old "/translation-management" to point to new page under Section "End User Guide"
  • Have hidden the old translations path, which is now available at "/translation-management-old"
  • Added a section on translating keys with placeholders

@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Aug 30, 2024
@mahalakshme mahalakshme moved this from In Code Review to Done in Avni Product Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants