Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abnormal flag when set via rule, doesn't show up in red #1438

Closed
Tracked by #1421
nupoorkhandelwal opened this issue Jun 24, 2024 · 1 comment
Closed
Tracked by #1421

Abnormal flag when set via rule, doesn't show up in red #1438

nupoorkhandelwal opened this issue Jun 24, 2024 · 1 comment
Assignees

Comments

@nupoorkhandelwal
Copy link
Collaborator

nupoorkhandelwal commented Jun 24, 2024

Describe the bug

  • There is an existing feature to display a value in red colour if required in the Program Summary. Currently its broken.
  • When set abnormal via rule it is not working.
  • Not working in 7.2 itself.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a program summary rule
  2. Add an observation from the program to display it this way (set - isAbnormal -true)
  3. summaries.push({name: "HB values", value: value, abnormal: isAbnormal})
  4. Save and sync the app, check the program summary
  5. The value isn't displayed in red as expected

Screenshots

Image

Need to fix the issue
Though we have new ways to set abnormal value via UI, from a product perspective, flexibility to set abnormal via rules is helpful for many cases.

Technical details

Additional AC
Add about this way of being able to mark from rule in readme

@nupoorkhandelwal nupoorkhandelwal moved this to New Issues in Avni Product Jun 24, 2024
@mahalakshme mahalakshme moved this from New Issues to In Analysis in Avni Product Jun 24, 2024
@pkundu
Copy link

pkundu commented Jun 24, 2024

@mahalakshme we can go live without this. But a good one to fix

@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Jun 24, 2024
@mahalakshme mahalakshme mentioned this issue Jun 24, 2024
@mahalakshme mahalakshme changed the title abnormal flag not working in program summary abnormal flag when set via rule, doesn't show up in red Jun 24, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Jun 24, 2024
@mahalakshme mahalakshme moved this from Ready to Analysis Complete in Avni Product Jun 24, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Jun 27, 2024
@mahalakshme mahalakshme changed the title abnormal flag when set via rule, doesn't show up in red Abnormal flag when set via rule, doesn't show up in red Jun 27, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jul 1, 2024
@petmongrels petmongrels self-assigned this Jul 1, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Jul 2, 2024
petmongrels added a commit that referenced this issue Jul 2, 2024
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jul 2, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Jul 3, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Jul 3, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 3, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants