Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the listing text color to black from grey #1415

Closed
mahalakshme opened this issue Jun 5, 2024 · 4 comments
Closed

Change the listing text color to black from grey #1415

mahalakshme opened this issue Jun 5, 2024 · 4 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jun 5, 2024

Need:

In the mockups it seems to be black. Having grey color, with the existing dark color bg, makes the text less visible and more card colors need to be changed.

AC:

Change the card list view text color to black, similar to that of card tile view.
Image

@mahalakshme mahalakshme converted this from a draft issue Jun 5, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Jun 5, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jun 5, 2024
@petmongrels petmongrels moved this from In Progress to Ready in Avni Product Jun 5, 2024
@himeshr himeshr moved this from Ready to In Progress in Avni Product Jun 7, 2024
@himeshr himeshr self-assigned this Jun 7, 2024
@himeshr
Copy link
Contributor

himeshr commented Jun 7, 2024

@mahalakshme have kept the description color same for tile and list. Its now set to same value as that was there previously for Tile View. But its not black, its hexcode is #333333.
Screenshot 2024-06-07 at 1 35 56 PM

@himeshr himeshr moved this from In Progress to QA Ready in Avni Product Jun 7, 2024
@himeshr
Copy link
Contributor

himeshr commented Jun 7, 2024

Minor code change, no code-review required.

@mahalakshme
Copy link
Contributor Author

mahalakshme commented Jun 7, 2024

@himeshr please make it black, with #333333 more card colors(like #3e50b4, #0f6560) need to be changed. I did the checking using here and hence suggested black

@mahalakshme mahalakshme moved this from QA Ready to Code Review with Comments in Avni Product Jun 7, 2024
@himeshr
Copy link
Contributor

himeshr commented Jun 7, 2024

Set both to be black by default.
Screenshot 2024-06-07 at 2 09 04 PM

@himeshr himeshr moved this from Code Review with Comments to QA Ready in Avni Product Jun 7, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jun 12, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants