Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile nav disables body scroll after dismissal #8

Open
aviflombaum opened this issue Jul 14, 2023 · 1 comment
Open

Mobile nav disables body scroll after dismissal #8

aviflombaum opened this issue Jul 14, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aviflombaum
Copy link
Owner

Because the mobile nav sheet is dismissed via the dialog controller and not the sheet controller, the overflow-hidden never gets removed from the body locking scroll after it appears. No bueno.
@aviflombaum aviflombaum added bug Something isn't working good first issue Good for newcomers labels Jul 14, 2023
@sergitejada sergitejada mentioned this issue Sep 7, 2023
Merged
aviflombaum added a commit that referenced this issue Sep 7, 2023
@aviflombaum
Merge pull request #44 from sergitejada/#8_mobile-nav-disables-body-s…
2121c9e 
…croll

#8 in mobile view remove overflow-hidden
@sergitejada
Copy link
Contributor

Change status @aviflombaum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aviflombaum @sergitejada