Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot device detection is always DeviceComputer #51

Open
thomas-schwebel opened this issue Jun 1, 2019 · 0 comments
Open

Bot device detection is always DeviceComputer #51

thomas-schwebel opened this issue Jun 1, 2019 · 0 comments

Comments

@thomas-schwebel
Copy link

Hi,

We've noticed that when the User-Agent is detected as bot is it always set as device type DeviceComputer.
This is not always correct. The GoogleBot for instance can crawl the page using different User-Agent for mobile or desktop.
See https://support.google.com/webmasters/answer/1061943?hl=en.
This library should reflect this when parsing a User-Agent. If the bot is crawling as a mobile phone it should be detected as DevicePhone.

I will submit a proposal as PR for fixing this.

Cheers,
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant