NEW: in case of column mismatch, the dataset will be created again #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @deepansh96! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-02-21 09:34:03 UTC |
| # download s3 file into lambda /tmp/ directory | ||
| file = s3_directory + table_name + ".csv" | ||
| local_file_name = "/tmp/" + table_name + ".csv" | ||
| s3.download_file(bucket_name, file, local_file_name) |
There was a problem hiding this comment.
is it possible to re-use these files in the process_tables function as well and avoid the download there? That may help with reduced run time for lambda.
Comment on lines
+43
to
+45
| if not are_public_columns_consistent or not are_schema_columns_consistent: | ||
| client.delete_dataset(dataset_id, delete_contents=True) | ||
| client.create_dataset(dataset_id) |
There was a problem hiding this comment.
I have a bit of different thoughts here. Instead of dropping the whole dataset, shouldn't we just drop and create at the table level?
If we do at the table level, I think then we can easily call this function inside process_tables function and avoid duplicate things like making BigQuery connection and S3 download files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Test Plan