You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In ValidatorManager.sol, NodeID is defined as bytes (a dynamically-sized type). I understand that this is probably done for future-proofing. However, when events are emitted like:
Its misleading, because the actual NodeID is not emitted, as Solidity will keccak the bytes to get a 32-byte hash to put in the event. So at a minimum I would suggest renaming it to NodeIDHash which would make it clear its not the actual nodeid.
Alternatively, I think if indexed is removed, the full value would be placed in the event log.
The text was updated successfully, but these errors were encountered:
In ValidatorManager.sol,
NodeID
is defined asbytes
(a dynamically-sized type). I understand that this is probably done for future-proofing. However, when events are emitted like:Its misleading, because the actual NodeID is not emitted, as Solidity will keccak the bytes to get a 32-byte hash to put in the event. So at a minimum I would suggest renaming it to
NodeIDHash
which would make it clear its not the actual nodeid.Alternatively, I think if
indexed
is removed, the full value would be placed in the event log.The text was updated successfully, but these errors were encountered: