only lookup staked account balance when needed #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
@bilgehansahin the PR looks correct to me. I am not sure it is enough of a workaround for the GetStake latency issue (your test will confirm).
It's pretty annoying not to be able to cache utxos by height properly. As you may know we don't have any plan to support this natively on AvalancheGo, but Glacier here may be the right solution.
bilgehansahin
force-pushed
the
pchain-balance-perf-fix
branch
from
17bada2
to
43bb554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we call GetStake for every account balance lookup call irrespective of the sub account type requested. In testnet this is not an issue but in mainnet, P-Chain
getStakeAPI calls can take upwards of 15-20 seconds. This change limitsgetStakecalls to total (default) and staked sub account type balance.Testing
Unit test, testnet data validation and mainnet spot check