From 7e6616705fb205e86b3888215eb8e2ed3b5c176f Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Tue, 18 Jun 2024 12:30:50 +0200 Subject: [PATCH] refactor(autoware_behavior_velocity_speed_bump_module): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez --- .github/CODEOWNERS | 2 +- planning/.pages | 2 +- .../autoware_behavior_velocity_planner/README.md | 2 +- .../autoware_behavior_velocity_planner/package.xml | 3 +-- .../test/src/test_node_interface.cpp | 2 +- .../CMakeLists.txt | 2 +- .../README.md | 0 .../config/speed_bump.param.yaml | 0 .../docs/speed_bump_design.svg | 0 .../docs/speed_bump_scenarios.svg | 0 .../docs/speed_bump_vel_calc.png | Bin .../package.xml | 4 ++-- .../plugins.xml | 2 +- .../src/debug.cpp | 0 .../src/manager.cpp | 0 .../src/manager.hpp | 0 .../src/scene.cpp | 0 .../src/scene.hpp | 0 .../src/util.cpp | 0 .../src/util.hpp | 0 .../README.md | 2 +- 21 files changed, 10 insertions(+), 11 deletions(-) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/CMakeLists.txt (86%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/README.md (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/config/speed_bump.param.yaml (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/docs/speed_bump_design.svg (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/docs/speed_bump_scenarios.svg (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/docs/speed_bump_vel_calc.png (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/package.xml (89%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/plugins.xml (71%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/src/debug.cpp (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/src/manager.cpp (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/src/manager.hpp (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/src/scene.cpp (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/src/scene.hpp (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/src/util.cpp (100%) rename planning/behavior_velocity_planner/{behavior_velocity_speed_bump_module => autoware_behavior_velocity_speed_bump_module}/src/util.hpp (100%) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1a6ec09d88d02..7766e458a89cf 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -197,7 +197,7 @@ planning/behavior_velocity_planner/autoware_behavior_velocity_no_stopping_area_m planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_module/** shumpei.wakabayashi@tier4.jp taiki.tanaka@tier4.jp tomoya.kimura@tier4.jp planning/behavior_velocity_planner/autoware_behavior_velocity_planner_common/** fumiya.watanabe@tier4.jp isamu.takagi@tier4.jp mamoru.sobue@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp planning/behavior_velocity_planner/autoware_behavior_velocity_run_out_module/** kosuke.takeuchi@tier4.jp makoto.kurihara@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp -planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/** mdogru@leodrive.ai shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp +planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/** mdogru@leodrive.ai shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp planning/motion_velocity_planner/autoware_motion_velocity_dynamic_obstacle_stop_module/** mamoru.sobue@tier4.jp maxime.clement@tier4.jp planning/motion_velocity_planner/autoware_motion_velocity_obstacle_velocity_limiter_module/** maxime.clement@tier4.jp planning/motion_velocity_planner/autoware_motion_velocity_out_of_lane_module/** maxime.clement@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomoya.kimura@tier4.jp diff --git a/planning/.pages b/planning/.pages index 3c868628198a8..0ebebc3c6ac7d 100644 --- a/planning/.pages +++ b/planning/.pages @@ -29,7 +29,7 @@ nav: - 'No Stopping Area': planning/behavior_velocity_planner/autoware_behavior_velocity_no_stopping_area_module - 'Occlusion Spot': planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_module - 'Run Out': planning/behavior_velocity_planner/autoware_behavior_velocity_run_out_module - - 'Speed Bump': planning/behavior_velocity_planner/behavior_velocity_speed_bump_module + - 'Speed Bump': planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module - 'Stop Line': planning/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module - 'Traffic Light': planning/behavior_velocity_planner/autoware_behavior_velocity_traffic_light_module - 'Virtual Traffic Light': planning/behavior_velocity_planner/autoware_behavior_velocity_virtual_traffic_light_module diff --git a/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/README.md b/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/README.md index f688318ed051e..041e0b86e0d06 100644 --- a/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/README.md +++ b/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/README.md @@ -19,7 +19,7 @@ It loads modules as plugins. Please refer to the links listed below for detail o - [Occlusion Spot](../autoware_behavior_velocity_occlusion_spot_module/README.md) - [No Stopping Area](../autoware_behavior_velocity_no_stopping_area_module/README.md) - [Run Out](../autoware_behavior_velocity_run_out_module/README.md) -- [Speed Bump](../behavior_velocity_speed_bump_module/README.md) +- [Speed Bump](../autoware_behavior_velocity_speed_bump_module/README.md) When each module plans velocity, it considers based on `base_link`(center of rear-wheel axis) pose. So for example, in order to stop at a stop line with the vehicles' front on the stop line, it calculates `base_link` position from the distance between `base_link` to front and modifies path velocity from the `base_link` position. diff --git a/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/package.xml b/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/package.xml index 24d11eb9d08d5..1d256b61fa861 100644 --- a/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/package.xml +++ b/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/package.xml @@ -66,7 +66,6 @@ ament_cmake_ros ament_lint_auto autoware_behavior_velocity_blind_spot_module - autoware_behavior_velocity_blind_spot_module autoware_behavior_velocity_crosswalk_module autoware_behavior_velocity_detection_area_module autoware_behavior_velocity_intersection_module @@ -74,12 +73,12 @@ autoware_behavior_velocity_no_stopping_area_module autoware_behavior_velocity_occlusion_spot_module autoware_behavior_velocity_run_out_module + autoware_behavior_velocity_speed_bump_module autoware_behavior_velocity_stop_line_module autoware_behavior_velocity_traffic_light_module autoware_behavior_velocity_virtual_traffic_light_module autoware_behavior_velocity_walkway_module autoware_lint_common - behavior_velocity_speed_bump_module rosidl_interface_packages diff --git a/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/test/src/test_node_interface.cpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/test/src/test_node_interface.cpp index 29cd7a215907f..cd6ba117fef35 100644 --- a/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/test/src/test_node_interface.cpp +++ b/planning/behavior_velocity_planner/autoware_behavior_velocity_planner/test/src/test_node_interface.cpp @@ -103,7 +103,7 @@ std::shared_ptr generateNode() get_behavior_velocity_module_config("no_stopping_area"), get_behavior_velocity_module_config("occlusion_spot"), get_behavior_velocity_module_config("run_out"), - get_behavior_velocity_module_config_no_prefix("speed_bump"), + get_behavior_velocity_module_config("speed_bump"), get_behavior_velocity_module_config("stop_line"), get_behavior_velocity_module_config("traffic_light"), get_behavior_velocity_module_config("virtual_traffic_light"), diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/CMakeLists.txt b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/CMakeLists.txt similarity index 86% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/CMakeLists.txt rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/CMakeLists.txt index f5d3a7078be9c..5262939c02ddf 100644 --- a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/CMakeLists.txt +++ b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/CMakeLists.txt @@ -1,5 +1,5 @@ cmake_minimum_required(VERSION 3.14) -project(behavior_velocity_speed_bump_module) +project(autoware_behavior_velocity_speed_bump_module) find_package(autoware_cmake REQUIRED) autoware_package() diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/README.md b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/README.md similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/README.md rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/README.md diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/config/speed_bump.param.yaml b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/config/speed_bump.param.yaml similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/config/speed_bump.param.yaml rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/config/speed_bump.param.yaml diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/docs/speed_bump_design.svg b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/docs/speed_bump_design.svg similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/docs/speed_bump_design.svg rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/docs/speed_bump_design.svg diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/docs/speed_bump_scenarios.svg b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/docs/speed_bump_scenarios.svg similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/docs/speed_bump_scenarios.svg rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/docs/speed_bump_scenarios.svg diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/docs/speed_bump_vel_calc.png b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/docs/speed_bump_vel_calc.png similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/docs/speed_bump_vel_calc.png rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/docs/speed_bump_vel_calc.png diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/package.xml b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/package.xml similarity index 89% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/package.xml rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/package.xml index 805ab2f39a7ef..6c38e194a63c2 100644 --- a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/package.xml +++ b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/package.xml @@ -1,9 +1,9 @@ - behavior_velocity_speed_bump_module + autoware_behavior_velocity_speed_bump_module 0.1.0 - The behavior_velocity_speed_bump_module package + The autoware_behavior_velocity_speed_bump_module package Tomoya Kimura Shumpei Wakabayashi diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/plugins.xml b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/plugins.xml similarity index 71% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/plugins.xml rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/plugins.xml index 48287a7f94b4b..7a37ec217e9a5 100644 --- a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/plugins.xml +++ b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/plugins.xml @@ -1,3 +1,3 @@ - + diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/debug.cpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/debug.cpp similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/debug.cpp rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/debug.cpp diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/manager.cpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/manager.cpp similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/manager.cpp rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/manager.cpp diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/manager.hpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/manager.hpp similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/manager.hpp rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/manager.hpp diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/scene.cpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/scene.cpp similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/scene.cpp rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/scene.cpp diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/scene.hpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/scene.hpp similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/scene.hpp rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/scene.hpp diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/util.cpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/util.cpp similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/util.cpp rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/util.cpp diff --git a/planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/util.hpp b/planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/util.hpp similarity index 100% rename from planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/src/util.hpp rename to planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/src/util.hpp diff --git a/planning/behavior_velocity_planner/autoware_behavior_velocity_template_module/README.md b/planning/behavior_velocity_planner/autoware_behavior_velocity_template_module/README.md index 4c90b8dd291ca..d37524e32b376 100644 --- a/planning/behavior_velocity_planner/autoware_behavior_velocity_template_module/README.md +++ b/planning/behavior_velocity_planner/autoware_behavior_velocity_template_module/README.md @@ -1,6 +1,6 @@ ## Template -A template for behavior velocity modules based on the behavior_velocity_speed_bump_module. +A template for behavior velocity modules based on the autoware_behavior_velocity_speed_bump_module. # Autoware Behavior Velocity Module Template