Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #15

Closed
4 tasks done
xmfcx opened this issue Mar 13, 2024 · 14 comments
Closed
4 tasks done

Release v1.0.0 #15

xmfcx opened this issue Mar 13, 2024 · 14 comments
Assignees
Labels
type:new-feature New functionalities or additions, feature requests.

Comments

@xmfcx
Copy link

xmfcx commented Mar 13, 2024

@xmfcx xmfcx added the type:new-feature New functionalities or additions, feature requests. label Mar 13, 2024
@xmfcx xmfcx moved this to Backlog in Autoware Labs Mar 19, 2024
@xmfcx xmfcx moved this from Backlog to Todo in Autoware Labs Apr 5, 2024
@lchojnack lchojnack moved this from Todo to In Progress in Autoware Labs Apr 16, 2024
@lchojnack
Copy link
Collaborator

I've started to work on this task. During set up I've encountered the issue described here. I think that the issue blocks this task.

@xmfcx xmfcx moved this to In Progress in Simulation Working Group Apr 17, 2024
@xmfcx
Copy link
Author

xmfcx commented Apr 17, 2024

@lchojnack we have also merged the latest updates to the documentation with:

Updated documentation page: https://autowarefoundation.github.io/AWSIM/main/

We are now waiting for the release, feel free to ask if you have any questions for this task.

@lchojnack
Copy link
Collaborator

lchojnack commented Apr 18, 2024

@xmfcx
I've produced the AWSIM binaries and here are my observations

AWSIM binary test

I've tested the binary with Autoware on tag 2024.04.

The binary works well, but I've noticed that green traffic lights are not detected well.
I've compared the result with the HDRP version of AWSIM to check if it was caused by the rendering pipeline. I think that changing to URP reduces Autoware traffic light detection performance.

Question: Is the not good green light detection acceptable for this release?

URP (AWSIM Labs) HDRP (AWSIM v.1.2.1)
vokoscreenNG-2024-04-18_08-35-03_1.webm
vokoscreenNG-2024-04-18_08-46-35_1.webm

AWSIM ss2 binary test

I've notice that the AWSIM labs branding are not applicable for ss2 scene.

Question: Is it acceptable for this release or just wait for fix?

AWSIM bin AWSIM ss2 bin
Screenshot_20240418_082037 Screenshot_20240418_082111

Github release

Questions:

@xmfcx
Copy link
Author

xmfcx commented Apr 19, 2024

Thanks @lchojnack

Traffic light problem

Before release, let's wait for this issue to be resolved:

Scenario simulator

For this release, let's keep scenario simulator out, we can do it in the next release.

Permissions

I've added you to the repository with Write permissions, please let me know if it doesn't work for you.

Version

This will be the 1.0.0 for the Autoware Labs.

@lchojnack
Copy link
Collaborator

@xmfcx

If the release will be 1.0.0, the version in left-bottom corner of UI shouldn't also point to 1.0.0 instead 1.2.0?

Screenshot_20240418_082037

@xmfcx
Copy link
Author

xmfcx commented Apr 19, 2024

Yes, It should be a part of the release PR, along with the doc updates.

@xmfcx
Copy link
Author

xmfcx commented Apr 24, 2024

I will release the current state with 3 lidars as a beta version 1.0.0-beta along with

To update relevant readme files and instructions.

When

is merged, let's to the 1.0.0 release.

@xmfcx xmfcx changed the title Release the next version of AWSIM binary with URP Release v1.0.0 Apr 24, 2024
@xmfcx xmfcx mentioned this issue Apr 24, 2024
3 tasks
@lchojnack lchojnack mentioned this issue May 8, 2024
4 tasks
@lchojnack
Copy link
Collaborator

@mozhoku @xmfcx
I'm trying to release v1.0.0, and I've noticed that the Graphy is missing when I run the AWISM from the main. The Graphy in the videos from #57 is present.

image

I assume that the Graphy should be visible, and it is a bug on main branch or in my setup.

Could you confirm that it is a bug and Graphy should be visible in the new UI or it is as expected and Graphy shouldn't be visible?

@lchojnack
Copy link
Collaborator

@mozhoku @xmfcx
Ok, I see what could be wrong. The Graphy is disabled on the scene by default.
Please let me know, Is it expected or is it a bug?

image

@mozhoku
Copy link
Collaborator

mozhoku commented May 9, 2024

@lchojnack
It should be enabled by default. I've forgot to turn it on at some point, my bad. Could you please turn it on? 🙏

@lchojnack
Copy link
Collaborator

@mozhoku
Thank you for the clarification. Yes, I will enable it.

@lchojnack
Copy link
Collaborator

@xmfcx
Release v1.0.0 is ready https://github.com/autowarefoundation/AWSIM/releases/tag/v1.0.0

@xmfcx
Copy link
Author

xmfcx commented May 10, 2024

@brkay54 could you test this v1.0.0 binary against the latest main branch of the Autoware?

@xmfcx
Copy link
Author

xmfcx commented May 10, 2024

Test video with AWSIM Labs 1.0.0: https://www.youtube.com/watch?v=GPow8YPgi1s

Thanks!

@xmfcx xmfcx closed this as completed May 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Simulation Working Group May 10, 2024
@xmfcx xmfcx moved this from In Progress to Done in Autoware Labs May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
Status: Done
Development

No branches or pull requests

5 participants