Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proof of ownership #998

Merged
merged 11 commits into from
Nov 28, 2024
Merged

Remove proof of ownership #998

merged 11 commits into from
Nov 28, 2024
+2,000 −706

Conversation

marc-aurele-besner
Copy link
Collaborator

@marc-aurele-besner marc-aurele-besner commented Nov 27, 2024 •
edited
Loading

Remove proof of ownership

  • Reactivate the staking route for Taurus network only
  • Removing proof of ownership from the registering operator form
  • Upgrade to Auto-SDK 1.0.10
  • Remove previously added temporary TS errors skipping

@marc-aurele-besner marc-aurele-besner linked an issue Nov 27, 2024 that may be closed by this pull request
Remove proof of ownership #996
Closed
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for dev-astral ready!

Name Link
🔨 Latest commit a485465
🔍 Latest deploy log https://app.netlify.com/sites/dev-astral/deploys/6748850a6685f80008957493
😎 Deploy Preview https://deploy-preview-998--dev-astral.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marc-aurele-besner marc-aurele-besner marked this pull request as ready for review November 28, 2024 13:59
jfrank-summit
jfrank-summit previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had same question in several spots: Why not use destructuring?

explorer/src/hooks/useConsensusData.ts Show resolved Hide resolved
explorer/src/components/Staking/RegisterOperators.tsx Show resolved Hide resolved
explorer/src/hooks/useTxHelper.ts Show resolved Hide resolved
@marc-aurele-besner marc-aurele-besner merged commit 927fd8a into main Nov 28, 2024
12 checks passed
@marc-aurele-besner marc-aurele-besner deleted the 996-remove-proof-of-ownership branch November 28, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrank-summit jfrank-summit jfrank-summit approved these changes

@clostao clostao Awaiting requested review from clostao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove proof of ownership
3 participants
@marc-aurele-besner @jfrank-summit @marcusDesk