Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make shadergen emit function definitions for all uses of nodegraphs #1062

Open
niklasharrysson opened this issue Dec 16, 2020 · 0 comments
Open

Make shadergen emit function definitions for all uses of nodegraphs #1062

niklasharrysson opened this issue Dec 16, 2020 · 0 comments
Assignees
@ashwinbhat @bernardkwok
Labels
ShaderGen Shader Generation change required
Milestone
1.39

Comments

@niklasharrysson
Copy link

Currently only the nodegraphs that are node implementations gets treated as separate function definitions. Nodegraphs that are just "compounds" are instead traversed through, extracting their nodes, when constructing the ShaderGraph to generate code from.

If we treated all nodegraphs as seprate function definitions it would simplify code generation. It would also avoid issues with name collisions for nodes inside vs outside a graph, if all nodegraphs resulted in separate ShaderGraph instances.
@niklasharrysson niklasharrysson added the ShaderGen Shader Generation change required label Dec 16, 2020
@bernardkwok bernardkwok mentioned this issue Dec 16, 2020
Open
@bernardkwok bernardkwok added this to the 1.39 milestone Mar 18, 2021
@bernardkwok bernardkwok self-assigned this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwinbhat ashwinbhat

@bernardkwok bernardkwok

Labels
ShaderGen Shader Generation change required
Projects
None yet
Milestone
1.39
Development

No branches or pull requests
3 participants
@ashwinbhat @niklasharrysson @bernardkwok