Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the visibility of symbols for MaterialX #1049

Open
ashwinbhat opened this issue Dec 3, 2020 · 0 comments
Open

Hide the visibility of symbols for MaterialX #1049

ashwinbhat opened this issue Dec 3, 2020 · 0 comments
Assignees
@ashwinbhat
Labels
Core Core change required
Milestone
1.39

Comments

@ashwinbhat
Copy link
Collaborator

When MaterialX is linked into multiple dylibs/so, symbols should be hidden so that they step on each other.
Add:
-fvisibility-inlines-hidden
-fvisibility=hidden
@ashwinbhat ashwinbhat added this to the 1.38 milestone Dec 3, 2020
@ashwinbhat ashwinbhat mentioned this issue Dec 3, 2020
Merged
@bernardkwok bernardkwok added the Core Core change required label Dec 3, 2020
@bernardkwok bernardkwok modified the milestones: 1.38, 1.39 Mar 18, 2021
ashwinbhat pushed a commit that referenced this issue Nov 14, 2022
@Tellusim
Fix color value and unnecessary BOM header (#1049)
5f41b4f 
- Color channel values should be separated by commas (standard_surface_copper.mtlx).
- Unnecessary BOM file header (lib/mx_microfacet_diffuse.glsl).
ashwinbhat pushed a commit that referenced this issue Jan 4, 2023
@pablode
Fix missing basis orthogonalizations in GLSL backend (#1177)
fefce08 
I've encountered shading artifacts in normal mapped MaterialX materials, and upon closer inspection I believe that these are caused by the missing basis orthogonalizations @Tellusim brought to attention in PR #1049.

However, instead of using a second normalize(cross(..)) call, I've applied the Gram-Schmidt algorithm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwinbhat ashwinbhat

Labels
Core Core change required
Projects
None yet
Milestone
1.39
Development

No branches or pull requests
2 participants
@ashwinbhat @bernardkwok