Optionally return status on WriteRelationships #1906
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a proof of concept for #1903.
It temporarily uses a
replace
statement ingo.mod
to use the files generated in https://github.com/benvernier-sc/authzed-go/tree/write_relationships_status from authzed/api#106.It defines a new
core
protobuf messageRelationTupleUpdateStatus
that corresponds to theRelationshipUpdateStatus
from the API protobuf.It then updates the signature of
ReadWriteTransaction.WriteRelationships
fromto
This allows to specify whether the store should return the status of the operations or not, and adds a return field with said statuses that are only guaranteed to be populated if
returnStatus
was true.All the usages of
WriteRelationships
store method were updated to ensure the code would still compile. TheWriteRelationships
gRPC handler was updated to actually pass theWithStatus
option from the request and use the returned statuses.So far only the Postgres implementation has been updated to honor the new options. All scenarios have been tested locally, but no automated tests have been written so far.