Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserManager stops resource loading if sign in fails #1788

Open
semvankoutrik opened this issue Dec 19, 2024 · 0 comments
Open

UserManager stops resource loading if sign in fails #1788

semvankoutrik opened this issue Dec 19, 2024 · 0 comments

Comments

@semvankoutrik
Copy link

I noticed that on initial load of a React app all pending resources are cancelled if redirecting to sign in failed. This happens when using UserManager with the default RedirectNavigator, because inside its close-function returned by prepare() it stops the window (MDN: The window.stop() stops further resources loading). This causes some fonts and HTTP-requests to be cancelled which in turn causes a weird looking error message for the user.

I couldn't think of any particular reason to stop the window, but I thought I'd ask before creating a PR to be certain: is there a particular reason targetWindow.stop() is called? If there is, can it be made configurable to not close the window?

For now I'll just copy the navigator, remove the line and insert it in the UserManager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant