Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make colorscheme.ts a module, instead of a classic script #4506

Open
louischan-oursky opened this issue Jul 29, 2024 · 1 comment
Open

Make colorscheme.ts a module, instead of a classic script #4506

louischan-oursky opened this issue Jul 29, 2024 · 1 comment

Comments

@louischan-oursky
Copy link
Collaborator

In #2058 (comment) we worked around FOUC by making colorscheme.ts a classic script. But the logic there is now needed to be reused. A classic script cannot import code for reuse. This issue is about

  • Reuse the logic in colorscheme.ts, by making it a module.
  • Make sure there is no FOUC with this change
@linear Linear
Copy link

linear bot commented Jul 29, 2024

DEV-1644 Make colorscheme.ts a module, instead of a classic script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@louischan-oursky