Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKGBUILD reviewing process #2

Open
ljmf00 opened this issue Jan 11, 2021 · 4 comments
Open

PKGBUILD reviewing process #2

ljmf00 opened this issue Jan 11, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ljmf00
Copy link
Member

ljmf00 commented Jan 11, 2021

There are a few questions I want to come up with in terms of the PKGBUILD reviewing process:

  • This will be the default behavior, although it will appear on every PKGBUILD or only the explicitly specified packages? Dependencies are shown by default or prompt?

I also propose the usage of ranger as an optional dependency for pretty reviewing and fallback to less
if ranger is not present.

ranger view example:
image

less view example:
image

@ljmf00 ljmf00 added the enhancement New feature or request label Jan 11, 2021
@FFY00
Copy link

FFY00 commented Jan 11, 2021

We open it in $EDITOR, also allowing it to be modified.

@ljmf00
Copy link
Member Author

ljmf00 commented Jan 11, 2021

We open it in $EDITOR, also allowing it to be modified.

Sure, but isn't preferred to analyze every file contained in the PKGBUILD context, like the local sources?

@FFY00
Copy link

FFY00 commented Jan 11, 2021

Sure, but we should still force the user to actually see the PKGBUILD by default. I think we should open the PKGBUILD in $EDITOR and then have a prompt asking if the user whishes to review the rest of the files. This would default to no, and when selected would run xdg-open /path/to/review/stuff.

@ljmf00
Copy link
Member Author

ljmf00 commented Jan 12, 2021

Sure, but we should still force the user to actually see the PKGBUILD by default. I think we should open the PKGBUILD in $EDITOR and then have a prompt asking if the user whishes to review the rest of the files. This would default to no, and when selected would run xdg-open /path/to/review/stuff.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants