Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP restructure and testing different decision layer structures #8

Merged
merged 18 commits into from
Dec 11, 2023
Merged

WIP restructure and testing different decision layer structures #8

merged 18 commits into from
Dec 11, 2023

Conversation

jamescalam
Copy link
Member

WIP, trying to find best way to allow different decision layer pipelines

@jamescalam jamescalam mentioned this pull request Dec 2, 2023
Closed
@jamescalam jamescalam requested a review from bruvduroiu December 2, 2023 22:51
bruvduroiu
bruvduroiu requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@bruvduroiu bruvduroiu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the tests. I'd only comment on the use of sum rather than average for picking top_class

semantic_router/layer.py Show resolved Hide resolved
@jamescalam jamescalam merged commit 4a81de1 into main Dec 11, 2023
3 checks passed
@jamescalam jamescalam deleted the james/matching-pipelines branch December 11, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvduroiu bruvduroiu bruvduroiu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescalam @bruvduroiu