Encode all decisions at once #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing now, in the meantime @simjak could we add tests to cover new code so we have tests passing? Thanks! |
jamescalam
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Looks good! I made a fix to the walkthrough.ipynb notebook for importing DecisionLayer object and updated the versions. Only thing that needs to be done is getting all tests to pass — once they all pass we can merge, thanks @simjak!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a performance issue where encoding was previously done individually for each decision.
Modifying the process to encode all decisions at once, significantly improved performance times.
Additionally, this PR includes enhancements to logging for better traceability and debugging.