-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Firefox support #216
base: master
Are you sure you want to change the base?
Conversation
Currently, the way this works breaks Chrome support (by hardcoding product), I will move this to a config value soon
Should be good to merge, I haven't tested though. |
Alright, just tested. The title appears but nothing shows on the actual window. |
Alright so adding --start-debugger-server did nothing apparently, I will have to do further investigation |
Alright, so it should work with Firefox Nightly, I can't confirm though. If anyone can test, that'd be helpful |
Alright, tried with Dev Edition, doesn't work... |
I did some more digging, I tried using |
Well, turns out that |
This reverts commit 908340e.
This reverts commit 442961c.
…owser-preview into firefox-support
…scode-browser-preview into firefox-support" This reverts commit 3859ffb, reversing changes made to 3831709.
Upgrading to Puppeteer 3 fixed the title, but it still doesn't display |
Showing the browser window shows that the weird navigation problem I mentioned here is solved, which is progress I guess? |
Using |
Fixes #215