Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Firefox support #216

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Conversation

zurgeg
Copy link

@zurgeg zurgeg commented Sep 1, 2021

Fixes #215

Currently, the way this works breaks Chrome support (by hardcoding product), I will move this to a config value soon
@zurgeg
Copy link
Author

zurgeg commented Sep 1, 2021

Should be good to merge, I haven't tested though.

@zurgeg
Copy link
Author

zurgeg commented Sep 1, 2021

Alright, just tested. The title appears but nothing shows on the actual window.

@zurgeg zurgeg marked this pull request as draft September 1, 2021 16:22
@zurgeg
Copy link
Author

zurgeg commented Sep 1, 2021

Alright so adding --start-debugger-server did nothing apparently, I will have to do further investigation

@zurgeg
Copy link
Author

zurgeg commented Sep 1, 2021

Alright, so it should work with Firefox Nightly, I can't confirm though. If anyone can test, that'd be helpful

@zurgeg
Copy link
Author

zurgeg commented Sep 1, 2021

Alright, tried with Dev Edition, doesn't work...
But, upon attempting to screenshot something (in headless mode), it... works? This indicates that the problem is somewhere in the code, time to do some more digging.

@zurgeg
Copy link
Author

zurgeg commented Sep 1, 2021

I did some more digging, I tried using puppeteer-core instead of puppeteer in tests, which couldn't reproduce the problem, I'll try on my desktop later to see if that fixes anything

@zurgeg
Copy link
Author

zurgeg commented Sep 2, 2021

So I took another look, and it appears to be navigating to networkservice,networkserviceinprocess.com???
image

@zurgeg
Copy link
Author

zurgeg commented Sep 2, 2021

Well, turns out that networkserviceinprocess happens to be a flag passed to Firefox, but this raises another question... does Firefox not support this flag? If so, disabling this flag which appears to be there by default could fix our problems

@zurgeg
Copy link
Author

zurgeg commented Sep 2, 2021

Upgrading to Puppeteer 3 fixed the title, but it still doesn't display

@zurgeg
Copy link
Author

zurgeg commented Sep 2, 2021

Showing the browser window shows that the weird navigation problem I mentioned here is solved, which is progress I guess?

@zurgeg
Copy link
Author

zurgeg commented Sep 2, 2021

Using -wait-for-browser allows navigation to work fully, we're getting close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox Support
1 participant