New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why lowercase in preproc? #7

Open

bittlingmayer opened this issue May 3, 2017 · 0 comments

bittlingmayer commented May 3, 2017

I noticed that the code lowers in preproc.

https://github.com/atpaino/deep-text-corrector/search?utf8=%E2%9C%93&q=lower%28%29&type=

Because of this:

The system can't use case as a clue.
The system can't correct case.

Did you try it without lowering at first, and there were problems?

(My instinct would be to avoid canonicalisation, and fight the out-of-dataset tokens with data.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment