Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgdown site fail (adsl_admiral no longer available) #237

Closed
4 tasks done
bms63 opened this issue Feb 14, 2024 · 1 comment · Fixed by #240 or #252
Closed
4 tasks done

pkgdown site fail (adsl_admiral no longer available) #237

bms63 opened this issue Feb 14, 2024 · 1 comment · Fixed by #240 or #252
Assignees
@averissimo

Comments

@bms63
Copy link
Collaborator

bms63 commented Feb 14, 2024 •
edited by averissimo
Loading

I believe we have our own adsl dataset available and the example should make use of it.

I believe if we remove this from adsl from admiral, then admiral can be removed from Suggests.

When the pkgdown action builds it can't find this object any longer...can someone look into this please? @atorus-research/xportr-development-team

image

Definition of Done

  • Remove admiral_adsl from examples
  • Update examples to use xportr adsl
  • Remove admiral from Suggests
  • Make sure site can rebuild.
@averissimo averissimo self-assigned this Feb 15, 2024
@averissimo averissimo mentioned this issue Feb 15, 2024
Merged
15 tasks
bms63 added a commit that referenced this issue Feb 27, 2024
@averissimo @bms63
Closes #237 Removes admiral dependency and corrects site (#240)
b479b71 
* feat: remove admiral from dependencies

* fix: remove redundant parameters

* update ADSL dataset

* fix: updates metadata and vignettes

* chore: lint and styler

* docs: updates news

* docs: Reframe adsl data source

* replace rlang::set_names with dplyr::rename_with

* docs: remove extra note

* docs: simplify example

* revert: bring back abort instead of stop

* fix: remove rlang from vignettes

* chore: explicit use of rlang and haven namespace

* feat: rename adsl to adsl_xportr and ADaM_admiral_spec.xlsx to ADaM_spec.xlsx

* docs: update NAMESPACE

* fix: corrects check errors / notes

* feat: data is non-lazy load and not easily accessible to user

* docs: update spec file

* docs: update news

* fix: updates example after merge

* fix: linter problem

---------

Co-authored-by: Ben Straub <[email protected]>
@averissimo averissimo linked a pull request Feb 28, 2024 that will close this issue
Closes #237 adds xportr_split and adsl_xportr _pkgdown.yml #252
Merged
15 tasks
@averissimo averissimo reopened this Feb 28, 2024
bms63 pushed a commit that referenced this issue Feb 28, 2024
@averissimo
Closes #237 adds xportr_split and adsl_xportr _pkgdown.yml (#252)
ad6ee23 
fix: include xportr_split and new adsl data file in pkgdown
@averissimo
Copy link
Collaborator

averissimo commented Feb 28, 2024 •
edited
Loading

The site builds and deployes 🎉

https://atorus-research.github.io/xportr/dev/reference/index.html

Thanks for the quick approval 🙇

@bms63 bms63 mentioned this issue Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averissimo averissimo

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@averissimo @bms63