Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: metadata should not be infered in xportr_write #226

Closed
averissimo opened this issue Jan 25, 2024 · 0 comments · Fixed by #227
Closed

Bug: metadata should not be infered in xportr_write #226

averissimo opened this issue Jan 25, 2024 · 0 comments · Fixed by #227
Assignees
@averissimo
Labels
bug Something isn't working programming

Comments

@averissimo
Copy link
Collaborator

What happened?

#190 introduced a bug by inferring metadata from the attributes in the data frame.

This is a new behavior that leads to errors as it will try to label the dataset with metadata that (usually) does not contain the information

Session Information

No response

Reproducible Example

No response
@averissimo averissimo added bug Something isn't working programming labels Jan 25, 2024
@averissimo averissimo self-assigned this Jan 25, 2024
This was referenced Jan 25, 2024
Merged
Merged
bms63 added a commit that referenced this issue Jan 29, 2024
@bms63
Merge pull request #227 from atorus-research/226_fix_xportr_write
c0dd2f0 
Closes #226 - `metadata` is no longer inferred on `xportr_write`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averissimo averissimo

Labels
bug Something isn't working programming
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #226 - metadata is no longer inferred on xportr_write atorus-research/xportr
1 participant
@averissimo