Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-arrange code to make tagging easier to follow #23

Open
atorger opened this issue Mar 16, 2021 · 0 comments
Open

Re-arrange code to make tagging easier to follow #23

atorger opened this issue Mar 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@atorger
Copy link
Owner

atorger commented Mar 16, 2021

This will probably never happen, but anyway, I am aware that the tagging translation is not so easy to follow in the code due to that it's made per layer and in-place, some parts left to later passes and then refined in multiple steps.

It would be easier to follow if we first just merge all layers and keep all NVDB tags. The SHP-files have only 8 character tag names which collide between layers so one would have to make a translation table, but it would be quite easy.

And then use that merged NVDB geometry as "read-only" tag-wise and write OSM tags to another, instead of like now translating in-place.

@atorger atorger added the enhancement New feature or request label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant