Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/: implement warnings-by-default #306

Open
jkeenan opened this issue Oct 12, 2020 · 3 comments
Open

lib/: implement warnings-by-default #306

jkeenan opened this issue Oct 12, 2020 · 3 comments

Comments

@jkeenan
Copy link
Collaborator

jkeenan commented Oct 12, 2020

In this ticket we will track our progress on implementing Objective 3, warnings-by-default, for tests in the lib/ directory in the core distribution. See that ticket for guidance on addressing warnings.

On Oct 11 I ran make test on the alpha-dev-03-warnings branch at commit 78482fc. I then chopped up the output into individual files, gzipped them, and placed them for your reference in this directory on my server.

By my count, the line count in the output file was 6659, which compares with a line count of 80 for the same group of files when I run make test on the alpha branch at commit c5c5fb4. So one, somewhat crude way of measuring our progress is how far we manage to reduce the line count in these test runs.

Acceptance Criteria: All tests for this subdirectory PASS; no tests emit warnings.

@jkeenan
Copy link
Collaborator Author

jkeenan commented Oct 27, 2020

I've been poking away at this ticket in the jkeenan/gha-306-warnings-lib-20201025 branch. There are two files that, as expected, are generating an enormous number of warnings. I have created separate tickets for those two.

@jkeenan
Copy link
Collaborator Author

jkeenan commented Dec 18, 2020

Pull request #348 should clear all but 2 test files underneath `lib'.

@jkeenan
Copy link
Collaborator Author

jkeenan commented Jan 25, 2021

As of Jan 24 2021, the only unit tests not passing in the lib/ subdirectory in the alpha-dev-03-warnings branch are:

    ../lib/Tie/Array/std.t
    ../lib/warnings.t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant