Study changes to t/op/*.t (10 of 12)

[jkeenan]

In this ticket we will study our progress in pursuit of Objective 2, "strict-by-default", for the following files in the Perl core distribution:

t/op/sprintf2.t
t/op/sselect.t
t/op/stash.t
t/op/stash_parse_gv.t
t/op/sub.t
t/op/sub_lval.t
t/op/substr.t
t/op/svleak.t
t/op/sysio.t
t/op/taint.t

These files should be evaluated in light of the guidelines presented on this wiki page. Please post the summary of your findings in a single comment in this issue.

First-time contributors: (1) Please post a comment to this ticket indicating you are working on it. That will enable us to assign the ticket to you. (GitHub won't let us do that until it already thinks you're part of the project.) (2) You should subscribe to this repository so that you get email updates.

Thank you for helping to improve the Perl programming language.

[brainbuz]

I can take a few more of these.

[brainbuz]

file	pass	strictures removed	reviewed diffs	notes
t/op/sprintf2.t	x	---	x	268 stricture
t/op/sselect.t	x	x	x
t/op/stash.t	x	---	x	60 stricture
t/op/stash_parse_gv.t	x	x	x
t/op/sub.t	x	---	x	189 use strict;
t/op/sub_lval.t	x	x	x
t/op/substr.t	x	x	x
t/op/svleak.t	x	x	x
t/op/sysio.t	x	x	x
t/op/taint.t	x	---	x	PR #313

taint.t had a global stricture and in a runperl block was testing the 'use' command with -T, in the PR I propose changing 'use strict' to 'use Getopt::Long', any Core module would serve the intention of the test.

[brainbuz]

Jim assigning this to you since my study is done and the only remaining question is which module should be used on the test of 'use' under Taint, and you are better qualified to pick one than me.