Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pp_ctl.c for use vX statements #172

Open
atoomic opened this issue Jul 27, 2020 · 5 comments
Open

Adjust pp_ctl.c for use vX statements #172

atoomic opened this issue Jul 27, 2020 · 5 comments
Labels

Comments

@atoomic
Copy link
Owner

atoomic commented Jul 27, 2020

t/comp/use.t and pp_ctl.c needs to be adjusted to respect these rules

Rules

my @bad = qw{
    use v8; # not sure - need decision
    use v6;
    use v6.1;
    use v6.0.1;
    use 6.001;
    # same with 'no' would be a bonus

    use v7.*; # index('v7.')
    use 7*; # index('7')

    use 5.10; => 5.100
    use 5.6;  => 5.600

    no v5;
    

};

my @good = qw{
    
    use v7;
    no v7;

    use v5;
    use v5.10;
    use 5.010;
};

Concept

	if (*ptr == '7' ) {
    	...
	}

	if (*ptr == 'v') ++ptr ;
	switch ( *ptr  ) {
		case '5':
			go back to 5 logic using vcmp but v5.32.255.255
		break;
		case '6':
			Sorry Perl 6 is not available in Perl 7
		break;

		case '7':
			/* warning use 7* is not supported 
		break;
		default: /* 8 is there not implemented */
			"Unknown behavior for use X"
	}
@atoomic atoomic added the objective mileposts for 'alpha' development label Jul 27, 2020
@jkeenan
Copy link
Collaborator

jkeenan commented Jul 28, 2020

Does this issue have to be resolved before we merge alpha-dev-01-bump-version branch into alpha branch?

Logistically, is it necessarily part of satisfying Objective 1? Or can it be done at a later point in the process (and if so, which objective)?

Thank you very much.
jimk

@atoomic
Copy link
Owner Author

atoomic commented Jul 28, 2020

IMO it's a new objective 1.1 but @toddr would prefer it sooner than later to perform some testing

@jkeenan
Copy link
Collaborator

jkeenan commented Jul 28, 2020

I'd like to reserve the "objective" label for those tickets that actually describe one of the (more or less) agreed-upon objectives.

I think for this ticket we should create a new label. Something along the lines of:

design-decision-needed

... because that's what comes first

@jkeenan
Copy link
Collaborator

jkeenan commented Jul 28, 2020

IMO it's a new objective 1.1 but @toddr would prefer it sooner than later to perform some testing

Here's my thinking.

On the one hand, it doesn't seem like it's needed either (a) to begin "outside" testing of what we've got so far (see email); or (b) what we need to satisfy Objective 1 and get to tag alpha-01 (and then commence work on Objective 2).

On the other hand, it's a design decision in which the Perl Steering Committee presumably needs to be consulted.

With the exception of Objective 16, all the objectives we've created so far have been things on which the Perl Steering Committee has made a decision. Not a written-in-stone decision, to be sure, but a decision nonetheless. As much as possible, I'd like to create objectives only for things on which the PSC has given a go-ahead.

I recommend that we tag c34cde5 as alpha-01-MC-0 and commence outside testing.

@toddr can then create a branch and start working up the various alternatives suggested in the OP for this ticket. Then, when the PSC makes its decision, we can merge that into whatever is the working branch at that moment. In other words, when the decision lands, the code is fee to land -- but we don't deem any objective unmet for lack of that decision/code in the meantime.

How does that sound?

Thank you very much.
Jim Keenan

@atoomic
Copy link
Owner Author

atoomic commented Jul 28, 2020

commit aa0e056 provides a start of the changes required to meet this sub-objective

I agree with tagging once merged

@atoomic atoomic added add-on and removed objective mileposts for 'alpha' development labels Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants