Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packbeam --external requires full path #29

Open
pguyot opened this issue Jun 20, 2024 · 2 comments · May be fixed by #36
Open

packbeam --external requires full path #29

pguyot opened this issue Jun 20, 2024 · 2 comments · May be fixed by #36

Comments

@pguyot
Copy link
Collaborator

pguyot commented Jun 20, 2024 •
edited
Loading

Surprisingly, it seems that

rebar3 atomvm packbeam -e estdlib/estdlib.avm -e eavmlib/eavmlib.avm

doesn't work and fails with enoent, while:

rebar3 atomvm packbeam -e `pwd`/estdlib/estdlib.avm -e `pwd`/eavmlib/eavmlib.avm

does work.

I guess the current working directory is not where rebar3 is invoked from. It should at least be mentioned in documentation.
@UncleGrumpy
Copy link
Collaborator

Indeed. It is only vaguely implied in the example of packing an external file… But not stated explicitly. I will change the help to say this should be the full path to the avm file, and make it clear in the documentation as well.

UncleGrumpy added a commit to UncleGrumpy/atomvm_rebar3_plugin that referenced this issue Sep 24, 2024
@UncleGrumpy
Allow relative path for --external AVMs in packbeam task
1135b9b 
Changes the way external AVMs are parsed to allow using a relative path to
the included `.avm` files.

Closes atomvm#29

Signed-off-by: Winford <[email protected]>
@UncleGrumpy UncleGrumpy linked a pull request Sep 24, 2024 that will close this issue
Open
UncleGrumpy added a commit to UncleGrumpy/atomvm_rebar3_plugin that referenced this issue Sep 24, 2024
@UncleGrumpy
Allow relative path for --external AVMs in packbeam task
8f0a9b4 
Changes the way external AVMs are parsed to allow using a relative path to
the included `.avm` files.

Closes atomvm#29

Signed-off-by: Winford <[email protected]>
@UncleGrumpy
Copy link
Collaborator

Please take a look at PR #36, it enables using relative paths as well for external AVMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow relative path for --external AVMs in packbeam task UncleGrumpy/atomvm_rebar3_plugin
2 participants
@pguyot @UncleGrumpy