Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow issue #7

Open
fariouche opened this issue Sep 20, 2024 · 0 comments
Open

Stack overflow issue #7

fariouche opened this issue Sep 20, 2024 · 0 comments

Comments

@fariouche
Copy link

Hello,
Thank you for the demo!

Just to let you know (and the others maybe) that the minimp3 code used here is "broken" for embedded use.
It will crash with a stack overflow (it requires more than 16KB of stack!)

You can update the copy with the one from the following repo: https://github.com/chmorgan/minimp3/blob/embedded/minimp3.h
Just donc put the mp3dec_t dec in the stack, but put it in global.
Bonus: the other minimp3 file also implement fixed point arithmetics, far better for the esp32.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant