Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_$template is not a function #9

Open
aminya opened this issue Dec 21, 2020 · 2 comments
Open

_$template is not a function #9

aminya opened this issue Dec 21, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@aminya
Copy link
Member

aminya commented Dec 21, 2020

Running pnpm test gives the following error:

> electron-mocha test --renderer --recursive --require @babel/register
× ERROR: _$template is not a function

This means that the babel compiler is not importing these functions

@aminya
Copy link
Member Author

aminya commented Dec 21, 2020

@ryansolid Do you have any idea why this happens?

Here is the babel config:
https://github.com/atom-ide-community/etch-solid/blob/master/babel.config.json

babel-preset-atomic is mostly a wrapper around babel-preset and a few other proposal plugins.

@aminya aminya added bug Something isn't working help wanted Extra attention is needed labels Dec 21, 2020
@ryansolid
Copy link
Contributor

Oh that is weird. I suppose to make sure the version of Solid and Babel Preset Solid match at least on the minor version. The only other thing I can think of is the change in package resolution to use export maps but I wouldn't expect that to be an issue here. Is this a new problem after an update? Template function is pretty much something that has been there since day one and should still be there.

On a different note, I also have some better tools now that might make this integration smoother. I've introduced mutable state which might work well here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants