From bd40ee0c8d625eb946a7c0be70cab82cd60e3378 Mon Sep 17 00:00:00 2001
From: "R. Miles McCain" <github@sendmiles.email>
Date: Mon, 26 Aug 2024 02:31:21 +0000
Subject: [PATCH] Update docs and remove unused workflow

---
 .github/workflows/deploy-gap.yml | 20 --------------------
 platform/deployments/README.md   |  2 +-
 2 files changed, 1 insertion(+), 21 deletions(-)
 delete mode 100644 .github/workflows/deploy-gap.yml

diff --git a/.github/workflows/deploy-gap.yml b/.github/workflows/deploy-gap.yml
deleted file mode 100644
index ef838ac93..000000000
--- a/.github/workflows/deploy-gap.yml
+++ /dev/null
@@ -1,20 +0,0 @@
-name: Fly Deploy GAP
-on:
-  push:
-    branches:
-      - deployments/gap
-env:
-  FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN_PROD }}
-jobs:
-  deploy:
-    name: Deploy app
-    runs-on: ubuntu-latest
-    concurrency:
-      group: ${{ github.ref }}
-    defaults:
-      run:
-        working-directory: ./platform
-    steps:
-      - uses: actions/checkout@v2
-      - uses: superfly/flyctl-actions/setup-flyctl@master
-      - run: LOG_LEVEL=debug flyctl deploy --config deployments/fly.gap.toml --build-arg APP_REVISION=${{ github.sha }} --wait-timeout 300
diff --git a/platform/deployments/README.md b/platform/deployments/README.md
index f13fa9f89..72bd4b92b 100644
--- a/platform/deployments/README.md
+++ b/platform/deployments/README.md
@@ -26,7 +26,7 @@ To setup continuous deployment, you'll need to configure a GitHub environment wi
 
 * `AZURE_CREDENTIALS`: The output of `az ad sp create-for-rbac --name "github-actions-<staging/prod>" --role contributor --scopes /subscriptions/<subscription_id>/resourceGroups/<resource_group_id> --json-auth`
   * Note (+ TODO): This credential is _overprovisioned_. Azure shockingly doesn't have a built-in role for "deploy to Azure Container Apps", so we have to use the `contributor` role. This is a security risk, but it's the best we can do for now without getting Azure P2 or P3. They [say](https://github.com/microsoft/azure-container-apps/issues/35#issuecomment-1675072081) that they will introduce more roles in Q4 2023.
-* `AZURE_CONTAINER_APP_NAME`: The name of the Azure Container App name
+* `AZURE_CONTAINER_APP_NAME`: The name of the Azure Container App (e.g., `ca-main-platform-staging-eastus`)
 * `AZURE_CONTAINER_APP_RESOURCE_GROUP`: The name of the Azure Container Apps resource group
 
 You'll also need to be sure that a corresponding GitHub Actions workflow file exists for the given deployment.