Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

375 stricter connection field check and error codes #378

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

YufengXin
Copy link
Collaborator

No description provided.

@YufengXin YufengXin self-assigned this Jan 14, 2025
@YufengXin YufengXin linked an issue Jan 14, 2025 that may be closed by this pull request
8 tasks
@YufengXin YufengXin marked this pull request as draft January 14, 2025 14:43
@YufengXin YufengXin marked this pull request as ready for review January 14, 2025 15:08
@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12770912448

Details

  • 7 of 11 (63.64%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 55.845%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/connection_handler.py 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
sdx_controller/handlers/connection_handler.py 1 75.0%
Totals Coverage Status
Change from base Build 12753378661: -0.09%
Covered Lines: 1113
Relevant Lines: 1993

💛 - Coveralls

@YufengXin YufengXin requested review from sajith and congwang09 and removed request for sajith January 14, 2025 15:08
@YufengXin YufengXin requested a review from gretelliz January 14, 2025 15:32
@YufengXin
Copy link
Collaborator Author

@gretelliz Please review this PR for the aggregated issue#375. I'll address your VLAN-related issues in the next PR.

@YufengXin YufengXin merged commit 73b1c2b into main Jan 15, 2025
11 checks passed
@YufengXin YufengXin deleted the 375-stricter-connection-field-check-and-error-codes branch January 15, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stricter connection field check and error codes
3 participants