Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end test fails when trying to create a L2VPN with incomplete body #361

Open
Tracked by #376
gretelliz opened this issue Jan 2, 2025 · 2 comments
Open
Tracked by #376
Assignees

Comments

@gretelliz
Copy link

gretelliz commented Jan 2, 2025

Testing the following example results in 'return status 200: Connection published'.

        // Body incomplete: vlan attribute is missing on an endpoint
        api_url = SDX_CONTROLLER + '/l2vpn/1.0'
        payload = {
            "name": "Test L2VPN request",
            "endpoints": [
                {"port_id": "urn:sdx:port:ampath.net:Ampath3:50","vlan": "500"},
                {"port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50"}
            ]
        }
        response = requests.post(api_url, json=payload)

Return code 400 should be obtained.
"400: Request does not have a valid JSON or body is incomplete/incorrect"

@gretelliz gretelliz changed the title End-to-end test fails with body incomplete End-to-end test fails with incomplete body Jan 2, 2025
@gretelliz gretelliz changed the title End-to-end test fails with incomplete body End-to-end test fails when trying to create a L2VPN with incomplete body Jan 2, 2025
@YufengXin
Copy link
Collaborator

@gretelliz Could you confirm if the issue is that the vlan information is missing from one port?
If so, I thought we should support it, ie, assign an available vlan by the sdx-controller.

@gretelliz
Copy link
Author

gretelliz commented Jan 9, 2025

@YufengXin That's right, the problem here is that the VLAN is not on one of the endpoints
{"port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50"} .

I think that assigning an available vlan is a valid solution, however this issue is related to the verification of the return code. According to the documentation, the request should return code 400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants