Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

General dataframes join transformer helper class #257

Open
FarBo opened this issue Feb 24, 2023 · 0 comments
Open

General dataframes join transformer helper class #257

FarBo opened this issue Feb 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@FarBo
Copy link
Contributor

FarBo commented Feb 24, 2023

At the moment, we have the following join transfomer:
https://github.com/atc-net/atc-dataplatform/blob/main/src/atc/transformers/join_dataframes_transformer.py

The problem is this is non-consuming join, and also it asks for strings for dataframes, which makes it unuseable for joining two dataframes as input arguments for the class.
The question is, should we extend this module with another more general class?
@LauJohansson
@sjkp

@LauJohansson LauJohansson added the enhancement New feature or request label Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants