Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't report on warnings #80

Open
vldslv-a opened this issue May 16, 2024 · 3 comments
Open

Doesn't report on warnings #80

vldslv-a opened this issue May 16, 2024 · 3 comments

Comments

@vldslv-a
Copy link

Hello! I've run into the following problem: it doesn't report eslint warnings
My config:

  - name: Annotate Code Linting Results
    uses: ataylorme/eslint-annotate-action@v3
    with:
      GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}
      report-json: reports/eslint_report.json
      only-pr-files: true
      fail-on-warning: true
      fail-on-error: true
      markdown-report-on-step-summary: true

As a result, I receive the following message:
image
But I don't see annotation about it in the PR. Could you fix it? This works well with errors, but not with warnings.

@beanow-at-crabnebula
Copy link

beanow-at-crabnebula commented May 22, 2024

Likewise, if there are both errors and warnings, the errors get reported in the summary but the warnings do not.

Mentioning:

Pull Request Changed Files ESLint Results:

1 ESLint error(s) and 0 ESLint warning(s) found

While this should actually be 1 error, 1 warning for my test case.

@beanow-at-crabnebula
Copy link

Disregard my comment.
The text actually gave the hint here. "Pull Request Changed Files".

Somewhere between v1.5.1 and v2.0.0 the behavior seems to have changed to only include errors/warning from code that was changed in that PR.

Maybe you were (also) expecting warnings from code that wasn't change in that PR?

@vldslv-a
Copy link
Author

vldslv-a commented May 23, 2024

Maybe you were (also) expecting warnings from code that wasn't change in that PR?

No, the problem is in the modified file.
A little above, I use tj-actions/changed-files@v42 to get the changed files and run the linter only for them
With only-pr-files: true, I had problems that it took into account ALL files, not just the modified ones. But that's a different issue, I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants