Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test cases for the contentType related topic #27

Closed
derberg opened this issue Aug 5, 2020 · 5 comments
Closed

Fix test cases for the contentType related topic #27

derberg opened this issue Aug 5, 2020 · 5 comments
Labels
bug Something isn't working stale

Comments

@derberg
Copy link
Member

derberg commented Aug 5, 2020

This issue is related to this PR #26 and this followup issue asyncapi/spec#421.

tl;dr the spec is not clear on the fact that contentType or defaultContentType are mandatory but also does not specify what would be default in case they are not provided. It will probably by application/json but still, this is not stated. This is not a bug but rather an improvement to the spec so change will not be published quickly

Now we have these test cases:

The easiest would be in my opinion to mark those that are invalid as valid for now and probably keep this issue open to look into the topic again once we release newer versions of the spec

@derberg derberg added the bug Something isn't working label Aug 5, 2020
@derberg
Copy link
Member Author

derberg commented Aug 5, 2020

@postatum what do you think? I see 👍 up from @fmvilas. I can open a PR right away

@postatum
Copy link
Contributor

postatum commented Aug 5, 2020

@postatum what do you think? I see +1 up from @fmvilas. I can open a PR right away

I'm ok with the changes you propose. Would appreciate the PR! 👍

@derberg
Copy link
Member Author

derberg commented Aug 5, 2020

@postatum it is out https://github.com/asyncapi/tck/pull/29/files

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Oct 5, 2020
@github-actions github-actions bot closed this as completed Nov 5, 2020
@derberg derberg removed the stale label Nov 5, 2020
@derberg derberg reopened this Nov 5, 2020
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jan 5, 2021
@github-actions github-actions bot closed this as completed Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants