Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the Visual JSON Schema Editor #1023

Closed
4 tasks
Amzani opened this issue Mar 18, 2024 · 21 comments · Fixed by #1065
Closed
4 tasks

Enhance the Visual JSON Schema Editor #1023

Amzani opened this issue Mar 18, 2024 · 21 comments · Fixed by #1065
Assignees
@Gmin2
Labels
bounty AsyncAPI Bounty enhancement New feature or request

Comments

@Amzani
Copy link
Collaborator

Amzani commented Mar 18, 2024 •
edited
Loading

After merging: #905
The visual editor needs to be enhanced for production

Scope

  • Look & Feel
  • Deletion
  • Nested objects
  • Test functionality

Complexity

Medium
@Amzani Amzani added the enhancement New feature or request label Mar 18, 2024
@Amzani Amzani changed the title feat: enhance the Visual JSON Schema Editor Enhance the Visual JSON Schema Editor Mar 18, 2024
@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty label Mar 18, 2024
@aeworxet
Copy link
Contributor

Bounty Issue's service comment

Text labels: bounty/2024-Q2, bounty/medium, bounty/coding
First assignment to third-party contributors: 2024-03-22 00:00:00 UTC+12:00
End Of Life: 2024-08-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

@koukama
Copy link
Contributor

koukama commented Mar 18, 2024

I can work on this issue ?

@aeworxet aeworxet moved this to No Assignee in Bounty Program Mar 18, 2024
@aeworxet
Copy link
Contributor

@koukama
Please specify your real name in your GitHub profile as per your passport/ID before participating in the Bounty Program, as it will be compared to the Legal Name / Full name of the account holder during the payout.
https://github.com/asyncapi/community/pull/897/files#diff-25ecb20a61754c225d6511ca08d7e7c9a14b9ca5a93e89bd42331e51c9ebf26dR186

@Amzani
Copy link
Collaborator Author

Amzani commented Mar 19, 2024

As @princerajpoot20 is currently busy and you seem interested in continuing his work please go ahead @koukama. In case you need more context feel free to coordinate with @princerajpoot20.

@fmvilas fmvilas mentioned this issue Mar 25, 2024
Merged
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Open
@Gmin2
Copy link
Contributor

Gmin2 commented Apr 2, 2024

@princerajpoot20 i will like to work on it if no one is working on it.
Thanks

@princerajpoot20
Copy link
Member

@utnim2 Please go ahead.

@princerajpoot20
Copy link
Member

Details about the Tasks

Things to Implement

  • Delete Property Function
  • Toggle Required/NotRequired Function
  • Change Type of Property Function
  • Add Property function, but only for cases which have a path containing array<object>.
  • UI look and feel according to the Figma design.

Some minor fixes:

  • When a property is of the type array, the data type of the array is not displayed in the visual editor.

@princerajpoot20
Copy link
Member

@utnim2 Let me know if you need any help.

@aeworxet
Copy link
Contributor

aeworxet commented Apr 2, 2024

Bounty Issue's Timeline

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2024-04-02 2024-04-08 2024-05-17 2024-04-19 2024-05-03 2024-05-17
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@aeworxet aeworxet moved this from No Assignee to In Progress in Bounty Program Apr 2, 2024
@Gmin2
Copy link
Contributor

Gmin2 commented Apr 2, 2024

@utnim2 Let me know if you need any help.

Hey @princerajpoot20 the figma link is broken in #748

@KhudaDad414
Copy link
Member

@utnim2 the link is Ok. I think something is wrong with Figma. first login Figma and then clink on that link. it should work. If that didn't help, you can try using this link

@Gmin2 Gmin2 mentioned this issue Apr 5, 2024
Merged
@aeworxet
Copy link
Contributor

#1065 (comment)

@aeworxet
Copy link
Contributor

Upon request of the Bounty Program Participant (@utnim2), all remaining target dates of the Bounty Issue's Timeline are extended by one calendar week.

Bounty Issue's Timeline Extended

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2024-04-02 2024-04-08 2024-05-24 2024-04-19 2024-05-10 2024-05-24
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@Bhavyajain21
Copy link

Is this issue still open?

@aeworxet
Copy link
Contributor

@Bhavyajain21
image

@princerajpoot20
Copy link
Member

princerajpoot20 commented May 30, 2024 •
edited
Loading

@aeworxet Could you please extend the deadline by two weeks? There are some changes left to be implemented by @Gmin2.
Thank you for the consideration. 🙂

@aeworxet
Copy link
Contributor

Upon request of the AsyncAPI Maintainer, who is currently leading the development (@princerajpoot20), all remaining target dates of the Bounty Issue's Timeline are extended by two calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2024-04-02 2024-04-08 2024-06-07 2024-04-19 2024-05-10 2024-06-07
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Bounty Program Jun 6, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Studio - Kanban Jun 6, 2024
@Amzani
Copy link
Collaborator Author

Amzani commented Jun 10, 2024

Accepted as done

@aeworxet
Copy link
Contributor

Bounty Issue Completed 🎉

@Gmin2, please go to the AsyncAPI page on Open Collective and submit an invoice for USD 200.00 with the expense title Bounty studio#1023, tag bounty, and full URL of this Bounty Issue in the description.

@Bhavyajain21
Copy link

Do we have a slack or a discord channel? @aeworxet

@aeworxet
Copy link
Contributor

@Bhavyajain21

There is a Slack Workspace.
You can find most people in it by their GitHub handles or names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gmin2 Gmin2

Labels
bounty AsyncAPI Bounty enhancement New feature or request
Projects
Bounty Program
Status: Completed
Studio - Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Enhancement of Visual Json Schema Editor Gmin2/studio
8 participants
@Amzani @aeworxet @koukama @KhudaDad414 @princerajpoot20 @asyncapi-bot @Bhavyajain21 @Gmin2