-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all argument constructor to generated classes and make setters like a builder #368
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Hello @vladigeras I'll think about it |
"About all argument constructor I see a drawback in readability when object has 10+ fields". I suggest, that all argument constructor can be added as optional way to create an object. If it unsuitable way, then programmer can skip it and use another way. Can we use record for class generation now? For example, with some generator parameters |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Reason/Context
Now generated classes have only one default no argument constructor and classic setters (set field value and return void).
I suggest at least one changes:
This changes can increase readability of generated classes and decrease unnecessary verbose when using models in client services.
Description
Add all argument constructor to generated classes OR (AND) make setters like a builder
The text was updated successfully, but these errors were encountered: