Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved courses revamp #658

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Saved courses revamp #658

merged 5 commits into from
Nov 27, 2023

Conversation

Jdyn
Copy link
Contributor

@Jdyn Jdyn commented Nov 26, 2023 •
edited
Loading

This PR depends on #637 due to it's internal catalog rework making this implementation very quick and easy.

This PR should be merged into catalog-context first, then merge #637 for a smooth transition.

  • Adds a recently viewed course-list to the catalog when no course is selected, making it easy to navigate back to a previously viewed course.
  • Adds the existing account saved course-list to the catalog when no course is selected.

See: https://save.berkeleytime.com/catalog

@Jdyn Jdyn self-assigned this Nov 26, 2023
@Jdyn Jdyn marked this pull request as ready for review November 27, 2023 04:12
@Jdyn Jdyn requested a review from mathhulk November 27, 2023 04:12
mathhulk
mathhulk approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mathhulk mathhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathhulk mathhulk merged commit 1a4c7c3 into catalog-context Nov 27, 2023
2 checks passed
@mathhulk mathhulk deleted the save branch November 27, 2023 08:00
mathhulk added a commit that referenced this pull request Jun 27, 2024
@mathhulk
Merge pull request #658 from asuc-octo/save
ca904e3 
Saved courses revamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathhulk mathhulk mathhulk approved these changes

Assignees

@Jdyn Jdyn

Labels
None yet
Projects
No open projects
Berkeleytime Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jdyn @mathhulk