-
Notifications
You must be signed in to change notification settings - Fork 7
Pull Requests & Reviews
Oscar Bjorkman edited this page Sep 19, 2020
·
2 revisions
Once you've written some 🔥 code, you'll want it pushed
- Divide pull requests into small tasks
- other people need to read your code and approve it, so lessen the burden!
- Push to your fork's relevant branch
- Submit a pull request into the this main repo's relevant branch
- please include a Markdown formatted description of what you've changed
- assign reviewers for approval
As a reviewer, you have a responsibility to thoroughly check pull requests.
Preventing is easier than tracking down bugs and fixing.
- Fetch the pull request
- actually run the code locally
- Read through every line of code
- does it follow the style guide?
- do class and variable names make sense?