Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PypeIt calibration line loading #231

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

hpparvi
Copy link
Contributor

@hpparvi hpparvi commented Nov 15, 2024

This PR fixes Issue #227 by converting the linelist table in specreduce.calibration_data.load_pypeit_calibration_lines from a Table to a QTable before calling specutils.utils.wcs_utils.vac_to_air. The vac_to_air function requires wavelengths to be given as Quantity objects, but the line list was a Table instead of a QTable.

… a QTable before calling `specutils.utils.wcs_utils.vac_to_air`.
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (2cc466d) to head (d88f5c1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   83.37%   83.36%   -0.02%     
==========================================
  Files          13       13              
  Lines        1137     1136       -1     
==========================================
- Hits          948      947       -1     
  Misses        189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@pllim pllim merged commit ef38dc0 into astropy:main Nov 15, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants