Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate contributing Dragon functionality to specreduce #56

Open
crawfordsm opened this issue Apr 10, 2020 · 2 comments
Open

Investigate contributing Dragon functionality to specreduce #56

crawfordsm opened this issue Apr 10, 2020 · 2 comments

Comments

@crawfordsm
Copy link
Member

The Dragon functionality from Gemini already works on NDData-like data, but it should be investigated if some of the functionality can be contributed directly to specreduce with a more agnostic approach to the use of NDData supported objects.

@chris-simpson

@kakirastern
Copy link

Stable version has been out at this stage: https://github.com/GeminiDRSoftware/DRAGONS/

@chris-simpson
Copy link

Just a couple of quick notes here to bring things up to date regarding the extra stuff we hang on our NDData-like objects (AstroData) that functions use.

  1. We have a variance attribute that returns an ndarray, making life much easier when using the noise properties to perform the necessary mathematics. Since we store the variance as a VarianceUncertainty instance, this is straightforward to implement, but I've suggested in API enhancement: Provide a standard "variance" property in all NDUncertainty classes, accessible to the parent NDData astropy#10128 that this be a read-only attribute of NDData. (It's settable in our framework but the functions of interest here don't use that functionality.)
  2. We have "descriptors" (callables that are attributes of the AstroData object) that provide information, e.g., dispersion_axis() describes the direction in which the spectrum is dispersed in a 2D spectrogram. I plan (once I have some time to do so) to remove these calls from the functions and instead have them as parameters of the function and decorate the functions in such a way that the parameter values get provided by the descriptors if an AstroData object, rather than an NDData object, is passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants