Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add image test for display in fluxcal.py #204

Open
pllim opened this issue Dec 7, 2023 · 0 comments
Open

TST: Add image test for display in fluxcal.py #204

pllim opened this issue Dec 7, 2023 · 0 comments
Labels
enhancement

Comments

@pllim
Copy link
Member

pllim commented Dec 7, 2023

Currently, this block is not tested:

specreduce/specreduce/fluxcal.py

Line 262 in aa4ceab

if display is True:

Since it is plotting, you might want to write a test where you compare the image, like how astropy.visualization does it. That would require additional CircleCI setup and a place to host the truth image(s).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pllim